Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: HIP-755 - add post implementation updates for accuracy #1098

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

lukelee-sl
Copy link
Member

Description:
Update several details in HIP-755 to better reflect the actual implementation.

@lukelee-sl lukelee-sl self-assigned this Jan 14, 2025
@lukelee-sl lukelee-sl requested a review from mgarbs as a code owner January 14, 2025 01:26
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit 5c31098
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/67911a4dcc7d3a0008ed0135
😎 Deploy Preview https://deploy-preview-1098--hedera-hips.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Luke Lee <[email protected]>
@david-bakin-sl david-bakin-sl changed the title chore: add post implementation updates for accuracy chore: HIP-755 - add post implementation updates for accuracy Jan 17, 2025
Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but with some suggestions if you're already doing another revision)

HIP/hip-755.md Show resolved Hide resolved
HIP/hip-755.md Show resolved Hide resolved
Copy link
Contributor

@stoyanov-st stoyanov-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgarbs mgarbs merged commit ac36e25 into main Jan 22, 2025
12 of 13 checks passed
@mgarbs mgarbs deleted the update-hip-755 branch January 22, 2025 17:35
stoyanov-st pushed a commit to stoyanov-st/hedera-improvement-proposal that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants