Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daily rewards for active nodes #1064
Daily rewards for active nodes #1064
Changes from all commits
1b73942
a3ee264
cf69045
bdd4e70
b20a89f
84da99d
d44642a
7fc7325
81ccfe3
e25468f
082eb24
bc391f4
e1d5d6f
aa5aea8
e3ea9db
11217cd
9801f0c
938e20e
ec10c9f
33f9478
f845541
72146fd
1132190
c52d0bb
34fb4a6
137f664
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this is following the usual pattern for use cases, but I find it weird nevertheless. How about something like:
"As a user of the network, I expect that non-active nodes do not receive any node rewards..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the node operator Michael?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I meant any regular user. It sounds weird for me to have a use case saying that somebody does not expect a certain behavior. However, as a regular user, I expect that the money I spend is only used for active nodes.
It's not important, though. It is clear what the expected behavior is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worthwhile to have both.
The current node operator use case, and another with text very similar to what @netopyr suggested.
It's good to be clear about expectations for both node operator and network user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah makes sense. Thanks @netopyr . Added another use case