Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: include ERC721 supported methods in README #190

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

acuarica
Copy link
Contributor

@acuarica acuarica commented Jan 14, 2025

Description:

This PR include supported methods from ERC721 in README, so that users are aware of the capabilities of the library/plugin.

Additionally, it uses . as a separator between notice and dev docs when needed.

Related issue(s):

Fixes #189.

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Luis Mastrangelo <[email protected]>
@acuarica acuarica requested review from a team as code owners January 14, 2025 19:12
@acuarica acuarica linked an issue Jan 14, 2025 that may be closed by this pull request
@acuarica acuarica added the docs Improvements or additions to documentation label Jan 14, 2025
quiet-node
quiet-node previously approved these changes Jan 14, 2025
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but some nits

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Luis Mastrangelo <[email protected]>
@acuarica
Copy link
Contributor Author

Thanks @quiet-node for pointing out the . separator. I've modified the script to include a . when necessary.

Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acuarica acuarica merged commit 5dbfa91 into main Jan 14, 2025
12 of 13 checks passed
@acuarica acuarica deleted the 189-update-readme-with-nft-methods branch January 14, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README with NFT methods
2 participants