-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: methods for transfer association and approval from the IHTS #188
base: main
Are you sure you want to change the base?
Conversation
…okenService interface (#151) Signed-off-by: Mariusz Jasuwienas <[email protected]>
b8cdcce
to
f28b6ef
Compare
…okenService interface (#151) Signed-off-by: Mariusz Jasuwienas <[email protected]>
…okenService interface (#151) Signed-off-by: Mariusz Jasuwienas <[email protected]>
…okenService interface (#151) Signed-off-by: Mariusz Jasuwienas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, it's looking good
…methods order, moving 22 const to lib, removing redundant comment (#151) Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, almost there
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff!
Description:
Adding the implementation of the methods from the IHederaTokenService interface. I will allow users to perform token-based operations by interacting with the HTS contract at the 0x167 address. The token-based operations introduced in this PR were already implemented on the token side through interfaces compatible with IERC721, IERC20, and IHRC719, but they have now been extended to support HTS calls as well.
For example, in addition to transferring a fungible token using the IERC20 interface
you can now perform the same operation via the HTS interface
Related issue(s):
#151
Notes for reviewer:
Checklist