-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hd_base example profile for OS X #776
Conversation
It looks good to me. Why is |
Because OS X does not have a Fortran compiler. See the comment in the file. This profile is a base profile that you build with the OS X native tools (in fact, just a pristine install of OS X 10.10 plus the default command line tools installation, triggered by typing "gcc" into the terminal the first time, is needed). Once you build this profile, then you have decent compilers and can compile the rest of Hashstack (with Fortran). |
I realize that. My question is why you need to set the parameter in a base profile. I guess you have packages in this base profile that may fail to build unless they're explicitly told not to build with fortran support. Seems to me that one would generally wait to build those in the downstream profile based on the gcc compilers built here. It's not a problem with your PR. I just want to make sure I'm clear on what is happening. |
Ah I see. Yes, it's probably not necessary, but it's nice to have it there as a remainder that this profile, if used as directed in the comments, will not build the whole Hashstack, only a minimal profile. |
lapack: | ||
use: host-osx-framework-accelerate | ||
mpi: | ||
use: mpich |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You won't get the Fortran compiler wrappers in this profile if you build MPI this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, the mpi will build without Fortran. To build it with Fortran, one needs to use #779.
I'm not sure what the purpose of this profile is. If it's just a builder, I would imagine that it only contains things like compilers, automake, etc... If it's something else, I'm not really sure what I'd use it for. |
It's a builder, so it has gcc, cmake, python, git and few other things that you might need to build packages, either as part of Hashstack, or manually. You are right about the MPI, that it doesn't have Fortran support. I personally use this profile as a base profile for #779. |
We can also later extend it to include Anyway, any objections against merging this? |
No objections. |
I am merging this. We can improve upon it later. |
Add hd_base example profile for OS X
@cekees, @ahmadia let me know what you think.
This profile requires #771 to be merged (well, strictly speaking it will build even without it, but then some other packages that you try to build with gcc will fail, so it's better to have it in, then you do not need to recompile once it is merged). I used the latest master (4637543).