Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade LEN_MAX up to 512 for all combinators by default #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AkechiShiro
Copy link

@AkechiShiro AkechiShiro commented Nov 24, 2023

  • Added a gcc argument in the Makefile CFLAGS for defining a variable LEN_MAX that will be set by default at 512.
  • if more is needed, running make LEN_MAX=<max_value_needed> will compile the combinators binaries with the proper changes.

I needed to combine wordlist that had long long strings, hence why this PR.

Was also assisted by @3ldidi94

* Added a gcc argument for defining a variable LEN_MAX that will be set
  by default at 512.
* if more is needed, running make LEN_MAX=<max_value> will compile the
  combinators binaries with the proper changes.
@AkechiShiro AkechiShiro changed the title Upgrade LEN_MAX up to 512 for all combinators Upgrade LEN_MAX up to 512 for all combinators by default Nov 24, 2023
@AkechiShiro
Copy link
Author

Hi @jsteube could you please approve the waiting workflow if it is relevant ?
Thanks also for making a review if possible, my solution might be too simple as I'm not familiar with all the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant