ApeCoinStake Strategy #79
Conversation
| } | ||
|
|
||
| function _liquidateReward() internal { | ||
| uint256 rewardBalance = IERC20(rewardToken()).balanceOf(address(this)); |
There was a problem hiding this comment.
We need additional logic to separate rewards from deposits, as underlying == rewardToken. See an example in the YEL strategy: https://github.com/harvest-finance/harvest-strategy/blob/master/contracts/strategies/yel/YelStrategy.sol#L136
There was a problem hiding this comment.
I noticed this problem and handled it differently in doHardWork function. But this approach is more obvious.
There was a problem hiding this comment.
I noticed this problem and handled it differently in
doHardWorkfunction. But this approach is more obvious.
But the problem is not resolved that way. When we have a balance in the rewardPool, and someone deposits into the vault, on doHardWork what happens is:
- Funds from the vault get transferred to the strategy (+APE balance)
- The strategy claims rewards from the rewardPool (+APE balance)
- At liquidation, the APE balance is queried and notified for profit share. This balance now includes the new deposit.
There was a problem hiding this comment.
Gotcha. Thanks for your clarification
New strategy for ApeStake
APECOINpool.The workflow of this strategy is relatively simple. It just deposits
APEto earnAPE, and compounds theAPEreward to the staking pool.Test outputs at blockNumber = 16233370: