Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apostrophe to tag. #608

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

rebeccacremona
Copy link
Contributor

This PR adds an apostrophe to the featured tag.

I updated the slugifying strategy, so that the apostrophe does not appear in the URL. (See these options). Reviewing the list of other tags (including those not currently linked on the site), I did not see that this causes the URLs associated with any other tags to change.

Copy link
Contributor

@bensteinberg bensteinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this will render as a curly quote, but I haven't checked.

@rebeccacremona
Copy link
Contributor Author

@bensteinberg Oh. Nope. Should I change it?

@bensteinberg
Copy link
Contributor

@bensteinberg Oh. Nope. Should I change it?

Yes, I think so? Since everything else in the site should be getting curlified.

@rebeccacremona rebeccacremona merged commit ee211ec into harvard-lil:redesign Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants