Fallback for 404ing blog post thumbnails #605
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this design, the list of blog posts is a series of labeled images. The logic is supposed to be as follows:
This PR fixes that: as is, the special thumbnail is overridden by a first image.
And, it adds special handling for when the first image 404s using this strategy, which I hadn't seen before.
I note you have to do this in two spots: the HTML include used by Jekyll.... and the javascript file used to render search results.
Before:
After: