Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Django #181

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

bensteinberg
Copy link
Contributor

This is a major version upgrade of Django. This is a first cut; tests pass locally, but I haven't examined the running application. I'm creating the PR in case anyone wants to take a look.

https://docs.djangoproject.com/en/4.2/releases/4.2.16/

https://docs.djangoproject.com/en/4.2/releases/4.2/

https://docs.djangoproject.com/en/4.2/releases/4.2/#backwards-incompatible-4-2

@rebeccacremona
Copy link
Collaborator

I see no important warnings/deprecations when running the tests locally; I can give the application a bit of a spin.

Copy link
Collaborator

@rebeccacremona rebeccacremona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM: I logged in locally and clicked around in the admin, and also ran it with my local Perma, and confirmed that if I initiated a purchase request, I was successfully forwarded to Cybersource's testing tier.

@bensteinberg bensteinberg merged commit a34396f into harvard-lil:develop Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants