Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css update for printable view and href base url update #2053

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

teovin
Copy link
Contributor

@teovin teovin commented Jul 18, 2024

  • Add base URL to CL relative URLs in the CL case HTML so we don't return a 404, and instead take the user to the CL website. PS: If there is a strong preference for us to use or not to use target="_blank", let me know and I can make an update accordingly.
    Sample casebook doc that would be fixed by this change: https://h2o-stage.lil.tools/casebooks/8195-test-casebook/resources/1-anderson-v-welding-testing-laboratory-inc/

  • Add a CSS attribute to all.css so the text inside <pre> tags do not overflow in the printable-html view. I used the same attribute here that we use for the regular view. This was impacting CAP-sourced legal docs as well.

CL case before:

image

CL case after:

image

@teovin teovin requested a review from a team as a code owner July 18, 2024 14:31
@teovin teovin requested review from cmsetzer and removed request for a team July 18, 2024 14:31
Copy link

@cmsetzer cmsetzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@teovin teovin merged commit dd67276 into harvard-lil:develop Jul 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants