Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View refactorings #8

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

View refactorings #8

wants to merge 17 commits into from

Conversation

jkraemer
Copy link

This PR addresses a few potential security problems due to usage of raw and lack of javascript escaping:

  • replaces all usages of the raw helper in views with safer alternatives.
  • introduces Javascript-escaping via the j helper.

Also some general refactorings:

  • extracted the progress_for_changeset helper method
  • re-used the existing show_assignments helper in another place
  • removed controller and request context arguments as these do not needed to be passed around like this

@jkraemer
removes uses of raw
13c0404
@jkraemer
removes unnecessary html escaping, it's always done automatically by …
1031d88 
…Rails
@jkraemer
remove unnecessary usage of raw
e5a5b00
@jkraemer
extract helper method
a51fa15
@jkraemer
refactor progress_for_changeset helper to use tag helpers
9f1491d 
- also removes the raw call which is now unnecessary and replaces it with java
  script escaping
@jkraemer
refactor show_assignments helper and update_diff_view
75d5fa6 
- removes another use of raw
- also introduces javascript escaping (j method) which is better than manually
  gsub'ing '-chars
@jkraemer
replaces raw with sanitize
29841bf 
- which is totally sufficient in this case
@jkraemer
adds url argument to popupReview
7d3178a
@jkraemer
use j helper instead of manual gsub
e81074a
@jkraemer
use the show_assignments helper in change_revision_view as well
9fa3df2
@jkraemer
remove unnecessary controller and requrest (sic) context values
4de5dda
@coveralls
Copy link

coveralls commented Mar 12, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 87.613% when pulling 40143ef on planio-gmbh:view-refactorings into 61f3a34 on haru:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkraemer @coveralls