Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove alias method chain and deprecated assertions #7

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove alias method chain and deprecated assertions #7

wants to merge 5 commits into from

Commits on Mar 8, 2018

  1. removes unnecessary require statements

    @jkraemer
    jkraemer committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    3094144 View commit details
    Browse the repository at this point in the history

  2. changes the way project_settings_tabs is extended 

    - alias_method_chain is deprecated and won't be available with Redmine 4
  anymore.
    @jkraemer
    jkraemer committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    66cff75 View commit details
    Browse the repository at this point in the history

  3. Changes CodeReviewChangesetPatch to use prepend 

    - alias_method_chain is deprecated
- also extracted a method to separate hooking into the Changeset lifecycle from
  what we actually want to do so it is more clear whats going on
    @jkraemer
    jkraemer committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    3cb9deb View commit details
    Browse the repository at this point in the history

  4. replaces deprecated assertions

    @jkraemer
    jkraemer committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    61c0bfc View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2018

  1. removes unused block arg

    @jkraemer
    jkraemer committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    ac73eb6 View commit details
    Browse the repository at this point in the history