Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [PL-58641]: add oidc support for gcp kms #1157

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

GokulBansal0
Copy link

@GokulBansal0 GokulBansal0 commented Jan 23, 2025

Title: Added GCP KMS connector support in terraform

Summary:
Provide a brief overview of what the PR does and why it is needed.

Details:
Explain the changes in detail, including any relevant context or background information.

Related Issues:
Reference any related issues or tickets

Testing Instructions:
Describe how the changes were tested. Include any test cases or steps to verify the functionality.
Please include the below test scenario with your changes.

  • Create the resource and execute terraform apply. (Verify the resource is created)
  • Execute terraform apply again without any changes. (Verify no changes should be done)
  • Update the resource and execute terraform apply. (Verify the resource updated successfully)
  • Remove the content from resource file and execute terraform apply. (Verify the resource has been deleted)
  • Add again the resource and execute the terraform apply. (Verify the resource is created)
  • Verify the import the resource file is working fine.
  • In case of remote entity, Verify for both default and non default branch.

Following Test Cases Added -

  1. KMS with Manual Credentials in All 3 scopes
  2. KMS with OIDC Credentials in all 3 scopes
  3. KMS as default secret manager

Screenshots:
Include before and after screenshots to visually demonstrate the changes.
Checklist:

  • Code changes are well-documented.
  • Tests have been added/updated.
  • Changes have been tested locally.
  • Documentation has been updated.
PR Check triggers
  • Build: trigger build
  • Sub Category Field Check: trigger subcategoryfieldcheck
  • gitleaks: trigger gitleaks

@GokulBansal0 GokulBansal0 marked this pull request as ready for review January 27, 2025 07:46
@GokulBansal0
Copy link
Author

trigger build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant