Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force mmacosx-version-min flag #7

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

scribam
Copy link

@scribam scribam commented Jul 26, 2024

This should be handled by CMake with CMAKE_OSX_DEPLOYMENT_TARGET

This should be handled by CMake with CMAKE_OSX_DEPLOYMENT_TARGET
@scribam
Copy link
Author

scribam commented Jul 26, 2024

Also fix the following warnings

ld: warning: object file (/Users/runner/work/discord-rpc/discord-rpc/builds/osx-static/examples/send-presence/CMakeFiles/send-presence.dir/send-presence.c.o) was built for newer 'macOS' version (14.0) than being linked (11.0)
ld: warning: object file (../../src/libdiscord-rpc.a2) was built for newer 'macOS' version (14.0) than being linked (11.0)
ld: warning: object file (../../src/libdiscord-rpc.a3) was built for newer 'macOS' version (14.0) than being linked (11.0)
ld: warning: object file (../../src/libdiscord-rpc.a4) was built for newer 'macOS' version (14.0) than being linked (11.0)
ld: warning: object file (../../src/libdiscord-rpc.a5) was built for newer 'macOS' version (14.0) than being linked (11.0)
ld: warning: object file (../../src/libdiscord-rpc.a6) was built for newer 'macOS' version (14.0) than being linked (11.0)

in https://github.com/harmonytf/discord-rpc/actions/runs/10115234476/job/27975531733#step:7:59 and

ld: warning: object file (/Users/runner/work/discord-rpc/discord-rpc/builds/osx-dynamic/src/CMakeFiles/discord-rpc.dir/discord_rpc.cpp.o) was built for newer 'macOS' version (14.0) than being linked (11.0)
ld: warning: object file (/Users/runner/work/discord-rpc/discord-rpc/builds/osx-dynamic/src/CMakeFiles/discord-rpc.dir/rpc_connection.cpp.o) was built for newer 'macOS' version (14.0) than being linked (11.0)
ld: warning: object file (/Users/runner/work/discord-rpc/discord-rpc/builds/osx-dynamic/src/CMakeFiles/discord-rpc.dir/serialization.cpp.o) was built for newer 'macOS' version (14.0) than being linked (11.0)
ld: warning: object file (/Users/runner/work/discord-rpc/discord-rpc/builds/osx-dynamic/src/CMakeFiles/discord-rpc.dir/connection_unix.cpp.o) was built for newer 'macOS' version (14.0) than being linked (11.0)
ld: warning: object file (/Users/runner/work/discord-rpc/discord-rpc/builds/osx-dynamic/src/CMakeFiles/discord-rpc.dir/discord_register_osx.m.o) was built for newer 'macOS' version (14.0) than being linked (11.0)

in https://github.com/harmonytf/discord-rpc/actions/runs/10115234476/job/27975531733#step:7:95

@p0358 p0358 merged commit 9d9e1c8 into harmonytf:master Oct 14, 2024
3 checks passed
@scribam scribam deleted the macos-version branch October 14, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants