booted-status to show booted for elected/signing validator, not boote…

…d for never elected (#2884)
harmony-one · Apr 25, 2020 · 9bbc3d0 · 9bbc3d0
1 parent 044c2dc
commit 9bbc3d0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/hmy/api_backend.go b/hmy/api_backend.go
@@ -415,6 +415,9 @@ func (b *APIBackend) GetValidatorInformation(
 
 	stats, err := bc.ReadValidatorStats(addr)
 	if err != nil {
+		// when validator has no stats, default boot-status to not booted
+		notBooted := effective.NotBooted.String()
+		defaultReply.BootedStatus = &notBooted
 		return defaultReply, nil
 	}
 

diff --git a/staking/effective/eligible.go b/staking/effective/eligible.go
@@ -78,8 +78,10 @@ func ValidatorStatus(currentlyInCommittee bool, status Eligibility) Candidacy {
 type BootedStatus byte
 
 const (
+	// Booted ..
+	Booted BootedStatus = iota
 	// NotBooted ..
-	NotBooted BootedStatus = iota
+	NotBooted
 	// LostEPoSAuction ..
 	LostEPoSAuction
 	// TurnedInactiveOrInsufficientUptime ..
@@ -90,6 +92,8 @@ const (
 
 func (r BootedStatus) String() string {
 	switch r {
+	case Booted:
+		return "booted"
 	case LostEPoSAuction:
 		return "lost epos auction"
 	case TurnedInactiveOrInsufficientUptime:

diff --git a/staking/types/validator.go b/staking/types/validator.go
@@ -127,7 +127,7 @@ func NewEmptyStats() *ValidatorStats {
 		numeric.ZeroDec(),
 		numeric.ZeroDec(),
 		[]VoteWithCurrentEpochEarning{},
-		effective.NotBooted,
+		effective.Booted,
 	}
 }