MINOR: Refine route-acl rules to prevent unintended prefix matches #692
+6
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
route-acl
annotated rules take precedence over others, this PR updates its behavior to ensure they do not unintentionally overwrite other rules that share the same word prefix.For example, a rule matching the path prefix
/api
should not inadvertently handle requests to/apiary
.To address this, the rule
{ path -m beg /api }
has been replaced with a alternative that validates the URL's termination, ensuring it matches only/api$
or/api/.*
:For better maintainability, this PR also refactors the
AddCustomRoute
function to eliminate redundancy introduced in commit c28d620. The updated code removes repetition without add extra spaces.