feat(kubernetes-ingress): Add Values.controller.extraEnvFrom to deployment and daemonset #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yment and daemonset Analogous to haproxytech#252, but for `kubernetes-ingress` chart.
dkorunic
reviewed
Aug 20, 2024
mecampbellsoup
force-pushed
the
mc/kubernetes-ingress/extraEnvFrom
branch
from
e2e4034
to
9ec9994
Compare
mecampbellsoup
force-pushed
the
mc/kubernetes-ingress/extraEnvFrom
branch
from
9ec9994
to
a4c64ab
Compare
|
@dkorunic ready! |
|
Looks good, merging. |
|
Thank you @dkorunic 😄 do you know when the next release tag is scheduled to be published that includes this? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to #252, but for
kubernetes-ingresschart.