BUG: kubernetes-ingress: Replace tpl with default #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `tpl` expects a string, passing an unqouted, fully-numeric image tag value results in a helm templating error, e.g.: ``` INFO[0000] install.go:214: [debug] Original chart version: "" install.go:231: [debug] CHART PATH: /home/mcampbell/github/coreweave/api-gateway/integration_tests Error: template: cloud-integration-tests/charts/cloud-app/charts/api-gateway/charts/kubernetes-ingress/templates/controller-deployment.yaml:91:74: executing "cloud-integration-tests/charts/cloud-app/charts/api-gateway/charts/kubernetes-ingress/templates/controller-deployment.yaml" at <.Values.controller.image.tag>: wrong type for value; expected string; got int64 helm.go:84: [debug] template: cloud-integration-tests/charts/cloud-app/charts/api-gateway/charts/kubernetes-ingress/templates/controller-deployment.yaml:91:74: executing "cloud-integration-tests/charts/cloud-app/charts/api-gateway/charts/kubernetes-ingress/templates/controller-deployment.yaml" at <.Values.controller.image.tag>: wrong type for value; expected string; got int64 subtask=0 task=Render std out err: %!(EXTRA *errors.errorString=install.go:214: [debug] Original chart version: "" install.go:231: [debug] CHART PATH: /home/mcampbell/github/coreweave/api-gateway/integration_tests Error: template: cloud-integration-tests/charts/cloud-app/charts/api-gateway/charts/kubernetes-ingress/templates/controller-deployment.yaml:91:74: executing "cloud-integration-tests/charts/cloud-app/charts/api-gateway/charts/kubernetes-ingress/templates/controller-deployment.yaml" at <.Values.controller.image.tag>: wrong type for value; expected string; got int64 helm.go:84: [debug] template: cloud-integration-tests/charts/cloud-app/charts/api-gateway/charts/kubernetes-ingress/templates/controller-deployment.yaml:91:74: executing "cloud-integration-tests/charts/cloud-app/charts/api-gateway/charts/kubernetes-ingress/templates/controller-deployment.yaml" at <.Values.controller.image.tag>: wrong type for value; expected string; got int64 ```
dkorunic
added a commit
that referenced
this pull request
May 23, 2024
Changes in kubernetes-ingress: - Replace tpl with default for Ingress Controller image tag (#244) Signed-off-by: Dinko Korunic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #243.
Summary
Instead of passing a templated string value
tag: "{{ .Chart.AppVersion }}"and relying ontplinside the templates that consume it, it is safer, less complicated, and more standardized to:tag: ""; and.Chart.AppVersion" logic inside the templates that consume that value.For example, grafana's charts use this same pattern (I lifted it from there):
Context
Since
tplexpects a string, passing an unqouted, fully-numeric image tag value (imagine a git commit SHA1 of53349267) results in a helm templating error, e.g.: