Skip to content

Commit

Permalink
FEATURE/MINOR: kubernetes-ingress: Parametrize metrics service type (#…
Browse files Browse the repository at this point in the history
…231)

Adds `controller.service.metrics.type` so that the metrics service's
type can be parametrized. The value defaults to `ClusterIP` for
backwards compatibility with previous versions of the Helm chart.
  • Loading branch information
mecampbellsoup authored Mar 25, 2024
1 parent 136ab3a commit af3c9d2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ metadata:
{{ $key }}: {{ $value | quote }}
{{- end }}
spec:
type: ClusterIP
type: {{ .Values.controller.service.metrics.type }}
ports:
- name: stat
port: {{ .Values.controller.service.ports.stat }}
Expand Down
2 changes: 2 additions & 0 deletions kubernetes-ingress/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,8 @@ controller:
## Controller Metrics Service configuration
## ref: https://kubernetes.io/docs/concepts/services-networking/service/
metrics:
type: ClusterIP # can be 'ClusterIP', 'NodePort' or 'LoadBalancer'

## Service annotations
## ref: https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
annotations: {}
Expand Down

0 comments on commit af3c9d2

Please sign in to comment.