fix: LanguageMessages type now supports languages in TypeScript #3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. The CI has nothing to do with you, I'll merge as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
messagesoption of any.validate() inconsistent with the documentation and actual code #2720This feature has always really been supported, but the type was correct all the time, resulting in build errors.
Only fixable with ugly
ts-expect-errorpatterns orts-patchfiles.It was really annoying to see this feature actually documented, but the type not being correct.
Multiple tests are already present, but this is one example:
https://github.com/hapijs/joi/blob/master/test/errors.js#L176-L196
Code that backs this up as being an existing and supported feature:
https://github.com/hapijs/joi/blob/master/lib/errors.js#L133-L143
Would love to hear back!