Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes related to VersionSpecificWorkerContextWrapper and new tests #6506

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

codeforgreen
Copy link
Collaborator

@codeforgreen codeforgreen commented Nov 23, 2024

Related to #6505

What was done:

  • updated all implementors of IValidationSupport to use Logs.getTerminologyTroubleshootingLog()
  • added a bunch of new tests on VersionSpecificWorkerContextWrapper related to the cache and also testing the methods to fetch validation resources at different levels (unit and integration).

Note that the initial scope of this PR was changed and it now does not include any functional change.

… that canonical CodeSystem resources are also cached. Use the terminology troubleshooting logs throughout the validation module.
Copy link

Formatting check succeeded!

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.18%. Comparing base (406db33) to head (0f8ddcc).
Report is 137 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6506      +/-   ##
============================================
- Coverage     83.54%   83.18%   -0.36%     
- Complexity    27432    28183     +751     
============================================
  Files          1707     1779      +72     
  Lines        106185   110130    +3945     
  Branches      13397    13848     +451     
============================================
+ Hits          88710    91614    +2904     
- Misses        11750    12546     +796     
- Partials       5725     5970     +245     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesagnew
Copy link
Collaborator

FYI @codeforgreen I believe this PR should be redundant once this merges (it also fixes the same issue by just never expiring StructureDefinions): #6508

@codeforgreen
Copy link
Collaborator Author

FYI @codeforgreen I believe this PR should be redundant once this merges (it also fixes the same issue by just never expiring StructureDefinions): #6508

I updated the scope of this PR to much smaller. I updated the description accordingly. It now just include the small compile warning or refactoring changes and additional tests. There is no change to the caches or validato, no changelog in this PR.

@codeforgreen codeforgreen changed the title Updates to the canonical validation resource cache in VersionSpecificWorkerContextWrapper Small changes related to VersionSpecificWorkerContextWrapper and new tests Dec 16, 2024
@codeforgreen codeforgreen enabled auto-merge (squash) December 16, 2024 23:14
@codeforgreen codeforgreen enabled auto-merge (squash) December 16, 2024 23:15
@codeforgreen codeforgreen merged commit 803e8ca into master Dec 18, 2024
63 of 65 checks passed
@codeforgreen codeforgreen deleted the 6505-validation-errors-profile-cache-expiry branch December 18, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants