-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small changes related to VersionSpecificWorkerContextWrapper
and new tests
#6506
Small changes related to VersionSpecificWorkerContextWrapper
and new tests
#6506
Conversation
… that canonical CodeSystem resources are also cached. Use the terminology troubleshooting logs throughout the validation module.
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6506 +/- ##
============================================
- Coverage 83.54% 83.18% -0.36%
- Complexity 27432 28183 +751
============================================
Files 1707 1779 +72
Lines 106185 110130 +3945
Branches 13397 13848 +451
============================================
+ Hits 88710 91614 +2904
- Misses 11750 12546 +796
- Partials 5725 5970 +245 ☔ View full report in Codecov by Sentry. |
FYI @codeforgreen I believe this PR should be redundant once this merges (it also fixes the same issue by just never expiring StructureDefinions): #6508 |
.../resources/ca/uhn/hapi/fhir/changelog/7_6_0/6505-validation-errors-profile-cache-expiry.yaml
Outdated
Show resolved
Hide resolved
hapi-fhir-storage/src/main/java/ca/uhn/fhir/jpa/validation/ValidatorResourceFetcher.java
Outdated
Show resolved
Hide resolved
.../org/hl7/fhir/common/hapi/validation/support/DefaultProfileValidationSupportNpmStrategy.java
Show resolved
Hide resolved
…ors-profile-cache-expiry
…ors-profile-cache-expiry
I updated the scope of this PR to much smaller. I updated the description accordingly. It now just include the small compile warning or refactoring changes and additional tests. There is no change to the caches or validato, no changelog in this PR. |
VersionSpecificWorkerContextWrapper
VersionSpecificWorkerContextWrapper
and new tests
Related to #6505
What was done:
IValidationSupport
to useLogs.getTerminologyTroubleshootingLog()
VersionSpecificWorkerContextWrapper
related to the cache and also testing the methods to fetch validation resources at different levels (unit and integration).Note that the initial scope of this PR was changed and it now does not include any functional change.