Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory overhead of searches #6471

Merged
merged 32 commits into from
Dec 5, 2024

Conversation

TipzCM
Copy link
Collaborator

@TipzCM TipzCM commented Nov 14, 2024

closes #6469

Copy link

github-actions bot commented Nov 14, 2024

Formatting check succeeded!

Copy link
Contributor

@michaelabuckley michaelabuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This isn't as fussy as I feared.

@TipzCM TipzCM enabled auto-merge (squash) November 21, 2024 18:16
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (406db33) to head (4b5b288).
Report is 113 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6471      +/-   ##
============================================
- Coverage     83.54%   83.36%   -0.18%     
- Complexity    27432    28044     +612     
============================================
  Files          1707     1763      +56     
  Lines        106185   109170    +2985     
  Branches      13397    13756     +359     
============================================
+ Hits          88710    91010    +2300     
- Misses        11750    12236     +486     
- Partials       5725     5924     +199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TipzCM TipzCM disabled auto-merge December 5, 2024 15:45
@TipzCM TipzCM enabled auto-merge (squash) December 5, 2024 15:57
@TipzCM TipzCM merged commit 265a5cd into master Dec 5, 2024
64 of 66 checks passed
@TipzCM TipzCM deleted the 6469-reduce-memory-overhead-of-searches branch December 5, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searches for large amounts of resources can use up a lot of in-memory resources
4 participants