This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Update form-display.vm #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checked to see if the config file is even needed. If not, then don't try to load it.
rgriffith
suggested changes
Apr 4, 2018
| define("AUTH_FILE_PATH", "${formConfigContent.getChild('authFilePath').text}"); | ||
| error_reporting(E_ALL); | ||
| <?php | ||
| #if( $wayToSave.text == "save-to-excel" || $wayToSave.text == "save-to-cms") |
There was a problem hiding this comment.
This actually won't work because $wayToSave is a loop variable from lines 11-19 above when setting some flags.
Instead the following will work:
#if( $excelSave == "true" || $cmsSave == "true")
|
@TWG-Matt Thank you for this submission. I had a review item that will need to be addressed before it can be merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked to see if the config file is even needed. If not, then don't try to load it.