Adding tests for the compatibility mode with OpenSSL #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keyword for openssl configuration is -no_middlebox
zhihan
reviewed
Aug 16, 2021
| @@ -97,6 +98,7 @@ print_usage() { | |||
| printf " -p|--peers\tWhich peers to use (Default: '%s')\n" "$PEERS" | |||
| printf " \tAlso available: GnuTLS (needs v3.2.15 or higher)\n" | |||
| printf " -M|--memcheck\tCheck memory leaks and errors.\n" | |||
| printf " -C|--compatibility\tTest TLS 1.3 compatibility mode (Default: '%s')\n" "$BOXES" | |||
There was a problem hiding this comment.
Curious: why not use -c? I don't think it is used yet.
zhihan
reviewed
Aug 16, 2021
| @@ -97,6 +98,7 @@ print_usage() { | |||
| printf " -p|--peers\tWhich peers to use (Default: '%s')\n" "$PEERS" | |||
| printf " \tAlso available: GnuTLS (needs v3.2.15 or higher)\n" | |||
| printf " -M|--memcheck\tCheck memory leaks and errors.\n" | |||
| printf " -C|--compatibility\tTest TLS 1.3 compatibility mode (Default: '%s')\n" "$BOXES" | |||
| printf " -v|--verbose\tSet verbose output.\n" | |||
There was a problem hiding this comment.
Should we sort the options alphabetically? If so we might want to move the help for -v up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keyword for openssl configuration is -no_middlebox
Status
READY
Requires Backporting
NO; for use with versions earlier than TLS 1.3 this feature has no equivalent.
Migrations
NO
Additional comments
With the help of the command line option -C (or --compatibility) the use of the compatibility mode can be enabled or disabled. Without the command line option, both cases will be tested.
Todos
Steps to test or reproduce
Run the following command in the tests directory:
This command will execute tests with and without the compability support.
Run the following commands to either enable or disable the use of the compability support in TLS 1.3 of OpenSSL.