Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to the processing of multiple tickets #161

Open
wants to merge 1 commit into
base: tls13-prototype
Choose a base branch
from

Conversation

hannestschofenig
Copy link
Owner

No description provided.

case MBEDTLS_ERR_SSL_RECEIVED_NEW_SESSION_TICKET:
/* We were waiting for application data but got a NewSessionTicket instead. */
/* We received a ticket via the NewSessionTicket message.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see, this code-path is specific to TLS 1.3 and has been removed from TLS 1.2 code below, but tickets are also used in TLS 1.2. I would like to make sure that our work on the prototype does not make it deviate further from a dual-build with 1.2.

Could you fix this?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MBEDTLS_SSL_NEW_SESSION_TICKET is TLS 1.3 specific but I will double-check that I didn't make any mistake here.

Copy link
Collaborator

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear to me that this maintains the ticket handling in the case of TLS 1.2.

Indepenently of that question, I think we should withhold withhold changes to example programs until #164 has been fixed -- otherwise, our life will be harder at a later point.

@hannestschofenig
Copy link
Owner Author

You are correct, Hanno, I changed the handling of the TLS 1.2 ticket with this PR. Since the Arm MbedTLS client/server example code has changed considerable in the meanwhile I believe it is better to re-build the TLS 1.3 server and client example application on top of the new code....

@hanno-becker
Copy link
Collaborator

@hannestschofenig Agreed -- let's revisit this after the next merge of development into tls13-prototype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants