Subscribe should not return null #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always returning null breaks the contract set in the function signature and documentation. This affects all subscribes that receive `IMqttMessageListener` as parameter. Signed-off-by: Fernando Governatore <[email protected]> Should pass IMqttActionListener on subscribe (#262) On subscribe, a failure would be reported but onSuccess would never be called. The reason was not passing the IMqttActionListener forward to MqttClient. Signed-off-by: Fernando Governatore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always returning null breaks the contract set in the function signature
and documentation.
This affects all subscribes that receive
IMqttMessageListeneras parameter.Should pass IMqttActionListener on subscribe (#262)
On subscribe, a failure would be reported but onSuccess would never be
called. The reason was not passing the IMqttActionListener forward to
MqttClient.
eclipse-paho/paho.mqtt.android#383