Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serializer #3

Merged
merged 12 commits into from
Apr 29, 2024
Merged

Add serializer #3

merged 12 commits into from
Apr 29, 2024

Conversation

simontaurus
Copy link
Collaborator

@simontaurus simontaurus commented Apr 27, 2024 •
edited
Loading

see #2
note: contains #1

hampusnasstrom
hampusnasstrom approved these changes Apr 29, 2024
View reviewed changes
Copy link
Owner

@hampusnasstrom hampusnasstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Maybe we should add some docstrings for the two exposed functions (parse_units and export_units) but I'll write a separate issue for that.

@simontaurus simontaurus merged commit 03e7e7b into main Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hampusnasstrom hampusnasstrom hampusnasstrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simontaurus @hampusnasstrom