Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve CLS issues in page layout #209

Merged
merged 2 commits into from
Nov 17, 2024
Merged

fix: resolve CLS issues in page layout #209

merged 2 commits into from
Nov 17, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 15, 2024

修复网页加载时页面布局的 CLS 问题,这个问题由 halo-dev/halo#6580 引发,因为之前的侧边栏布局采用 flex 布局,会导致在分块传输过程中,首先左边内容会自动铺满宽度,等侧边传输完成后又会改变会正常的布局,从而导致 CLS 问题,这个 PR 只是通过 CSS 规避这个问题,我建议重新考虑是否要在 Halo 中默认启用分块传输。

Screen.Recording.2024-11-15.at.21.28.18.mov
Screen.Recording.2024-11-15.at.21.29.46.mov

cc @JohnNiang

/kind improvement

修复网页加载时页面布局的 CLS 问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Nov 15, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and lan-yonghui November 15, 2024 13:25
Copy link

f2c-ci-robot bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ruibaby. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2024
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2024
@ruibaby ruibaby merged commit 235c2c2 into main Nov 17, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant