Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use AWS CLI v2 #1307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: use AWS CLI v2 #1307

wants to merge 1 commit into from

Conversation

florianesser
Copy link
Member

@florianesser florianesser commented Jan 31, 2025

Use AWS CLI v2 as v1 does not seem to be supported anymore on Ubuntu 24.04 (see also this issue comment.

@stempler Do you remember why v1 is used here explicitly? And is there a good way of testing a change like this without merging it to master first?

Use AWS CLI v2 as v1 does not seem to be supported anymore on Ubuntu 24.04 (see
also [this issue comment](unfor19/install-aws-cli-action#31 (comment)).
Copy link

This PR cannot be merged yet because a required label is missing: challenged. It needs to be added before this PR can be merged.

Copy link

hale studio builds for this pull request:

Build triggered for commit d77b09d.
Artifacts are retained for 14 days.

@stempler
Copy link
Member

Do you remember why v1 is used here explicitly?

Mainly because the original functionality was implemented using version 1 and when migrating to GitHub actions I retained that and did not invest the time to check if it works with version 2 ore if there may be changes required.

And is there a good way of testing a change like this without merging it to master first?

Not that I'm aware of. Maybe checking if the commands used still should work with version 2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants