Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'controlsOnlyForSpeaker' option #3716

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

gpotter2
Copy link
Contributor

Hi. Thanks for this great project.

This tiny PR adds a setting 'controlsOnlyForSpeaker' that only displays the controls for the presenter.

Copy link

@jdeniau jdeniau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not related to reveal.js, but I think that this could be a value for controls:

controls: boolean | 'speaker-only';

This way, we could implement 'display-only' of other kind of extension. Moreover, it avoid adding another prop to the API.

@hakimel
Copy link
Owner

hakimel commented Dec 11, 2024

I like @jdeniau's suggestion here. Can you update it so that this mode is enabled via controls: 'speaker-only'?

@gpotter2 gpotter2 force-pushed the controls-for-speaker branch from 131bc2c to 3751715 Compare January 11, 2025 15:50
@gpotter2
Copy link
Contributor Author

Done, sorry for the delay.

@hakimel
Copy link
Owner

hakimel commented Jan 13, 2025

Looks great, thanks!

@hakimel hakimel merged commit 6527f4d into hakimel:master Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants