-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add onnxslim support #215
base: experimental
Are you sure you want to change the base?
add onnxslim support #215
Conversation
Signed-off-by: inisis <[email protected]>
Reviewer's Guide by SourceryThis pull request updates the README.md file to include information about optimizing the inswapper_128_fp16.onnx model using onnxslim. The change provides users with an optional step to improve the performance of the model. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @inisis - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding more context about the benefits of using onnxslim for optimization (e.g., reduced file size, improved inference speed).
- It might be beneficial to move this optimization tip to a separate 'Advanced Usage' or 'Optimization' section in the documentation to keep the basic setup instructions clear and concise.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -26,7 +26,10 @@ Users of this software are expected to use this software responsibly while abidi | |||
1. [GFPGANv1.4](https://huggingface.co/hacksider/deep-live-cam/resolve/main/GFPGANv1.4.pth) | |||
2. [inswapper_128_fp16.onnx](https://huggingface.co/hacksider/deep-live-cam/resolve/main/inswapper_128_fp16.onnx) | |||
|
|||
Then put those 2 files on the "**models**" folder | |||
Then put those 2 files on the "**models**" folder, you can further optimize inswapper_128_fp16.onnx by using [onnxslim](https://github.com/inisis/OnnxSlim) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (documentation): Change 'on the "models" folder' to 'in the "models" folder'.
The correct preposition is 'in' rather than 'on' when referring to placing files within a folder.
As per checking, it just doesn't work based on the description Exception in Tkinter callback |
@hacksider Hi, there seems to be a version mismatch, you can check the similar issue here or official doc, and can you attch your onnx and onnxruntime version |
and if you want to use the slimmed model, it's preferred to slim under the same environment. |
@hacksider is there any updates, I have tested and it really works. |
@hacksider Hi, is there any updates? |
Summary by Sourcery
Update README.md to provide additional instructions for optimizing the inswapper_128_fp16.onnx model using onnxslim.
Documentation: