Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add onnxslim support #199

Closed
wants to merge 2 commits into from
Closed

add onnxslim support #199

wants to merge 2 commits into from

Conversation

inisis
Copy link

@inisis inisis commented Aug 12, 2024

#198

Summary by Sourcery

Add support for onnxslim by updating the README.md with instructions on how to optimize the inswapper_128_fp16.onnx model.

Documentation:

  • Update README.md to include instructions for optimizing the inswapper_128_fp16.onnx model using onnxslim.

Signed-off-by: inisis <[email protected]>
Copy link
Contributor

sourcery-ai bot commented Aug 12, 2024

Reviewer's Guide by Sourcery

This pull request adds support for optimizing the 'inswapper_128_fp16.onnx' model using the 'onnxslim' tool. The changes are implemented by updating the README.md file to include instructions on how to use 'onnxslim' for model optimization.

File-Level Changes

Files Changes
README.md Updated the README.md file to include instructions for optimizing the 'inswapper_128_fp16.onnx' model using 'onnxslim'.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @inisis - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a brief explanation of what onnxslim does and its benefits (e.g., reduced model size, faster inference).
  • Include instructions on how to install onnxslim, or add it to the project's dependencies if it's not already included.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

README.md Outdated
Comment on lines 29 to 31
Then put those 2 files on the "**models**" folder, you can further optimize inswapper_128_fp16.onnx by using
```
onnxslim inswapper_128_fp16.onnx inswapper_128_fp16.onnx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (documentation): Consider adding a brief explanation for the onnxslim command.

Adding a brief explanation or a link to the onnxslim documentation would help users who are not familiar with this tool.

Suggested change
Then put those 2 files on the "**models**" folder, you can further optimize inswapper_128_fp16.onnx by using
```
onnxslim inswapper_128_fp16.onnx inswapper_128_fp16.onnx
Then put those 2 files on the "**models**" folder. You can further optimize inswapper_128_fp16.onnx by using onnxslim:

onnxslim inswapper_128_fp16.onnx inswapper_128_fp16.onnx


onnxslim is a tool that reduces the size of ONNX models by removing unnecessary data. For more information, visit: https://github.com/onnx/optimizer

Signed-off-by: inisis <[email protected]>
@inisis inisis mentioned this pull request Aug 12, 2024
@inisis inisis closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant