-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hacky holidays cookie keychain #1430
base: main
Are you sure you want to change the base?
Conversation
Hi, I'm Orpheus Leap! Here to help you review your PR.
projects/candy's-cookie: Required files
You can view a render of your board over on gerber.zip/2d! Happy OnBoarding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all really cool design! The LEDs in your schematic are economic assembly, the TPS61027DRCR is not and also at 1.97$ per piece over budget, if possible could you replace it (maybe with like a TLV1117)? We'd be fine with allowing it, but if you can replace it, that'd be great! Also check that the 1000uF capacitor is correct, for a decoupling cap it seems very high in value! Besides that looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since JLCPCB changed LEDs to standard assembly we are currently looking at ways of fixing that, if you have no other standard assembly parts consider your PCB effectively approved!
Besides that are you able to solder the XIAO yourself or will you need it soldered?
Also I'll mark this as stalled, not because it is but because you're effectively done and we're figuring out the JLCPCB thing.
Submission Checklist:
#electronics
channel on Slackonboard/projects
TEMPLATE.md
asREADME.md
inside your project foldergerber.zip
andschematic.pdf
inside your project foldersrc
and uploaded design filescart.png
with all costs includedbom.csv
(Bill of Materials) file with the appropriate JLCPCB/LCSC Part numbers in the/src
directorypositions.csv
file in the/src
directoryFootnotes
Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials. ↩
OnBoard Live is a special version of OnBoard where you can earn more money for designing advanced boards. Check out the #onboard-live channel on our Slack! ↩
Hacky Holidays is a limited-time PCB event, design a holiday-themed PCB this Winter, and get it shipped. ↩