feat: 🎸 Type constraints prohibit returning undefined

ha0z1 · Mar 15, 2024 · 24f9ca3 · 24f9ca3
1 parent a038f59
commit 24f9ca3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "idmp",
-  "version": "1.15.1",
+  "version": "1.15.2",
   "keywords": [
     "deduplicate network requests",
     "idempotent function",

diff --git a/plugins/browser-storage/src/index.ts b/plugins/browser-storage/src/index.ts
@@ -3,6 +3,8 @@ import { getOptions, type Idmp, type IdmpOptions, type IdmpPromise } from 'idmp'
 const udf = undefined
 
 type StorageType = 'localStorage' | 'sessionStorage'
+type NonVoid<T> = T extends void ? never : T
+
 const getCacheKey = (globalKey: string) => `@idmp/v1/${globalKey}`
 
 const initStorage = (storageType: StorageType) => {
@@ -66,7 +68,7 @@ const storageIdmpWrap = (
   const storage = initStorage(storageType)
   const newIdmp = <T>(
     globalKey: string,
-    promiseFunc: IdmpPromise<T>,
+    promiseFunc: IdmpPromise<NonVoid<T>>,
     options?: IdmpOptions,
   ) => {
     const finalOptions = getOptions(options)

diff --git a/plugins/node-fs/src/index.ts b/plugins/node-fs/src/index.ts
@@ -48,10 +48,12 @@ const getData = async <T = any>(key: string) => {
   return data as T
 }
 
+type NonVoid<T> = T extends void ? never : T
+
 const fsIdmpWrap = (_idmp: Idmp) => {
   const newIdmp = <T>(
     globalKey: string,
-    promiseFunc: IdmpPromise<T>,
+    promiseFunc: IdmpPromise<NonVoid<T>>,
     options?: IdmpOptions,
   ) => {
     const finalOptions = getOptions(options)