Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAT-104 Add functionality to clear/reset AQUA settings to "default" #58

Merged
merged 3 commits into from
Oct 8, 2023
Merged

JAT-104 Add functionality to clear/reset AQUA settings to "default" #58

merged 3 commits into from
Oct 8, 2023

Conversation

selinali2010
Copy link
Collaborator

@selinali2010 selinali2010 commented Sep 22, 2023 •
edited
Loading

Summary

  • Add option to clear gains on all filters
  • Add options to reset parametric EQ to a fixed band EQ

Core Changes

  • Add headers for the "Auto EQ" and "Parametric EQ" sections
  • Add constants for the frequencies for fixed bands
  • Add new functions clearGains and setFixedBand
  • Add buttons in the UI to clear gains and set fixed bands

Miscellaneous

  • Shrink size of the sliders to accommodate new headers

Screenshots

image

@selinali2010 selinali2010 marked this pull request as ready for review September 22, 2023 01:46
h39s
h39s previously approved these changes Oct 1, 2023
View reviewed changes
Copy link
Owner

@h39s h39s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally for now, it is very nice that clear gains doesn't affect pre-amp unless auto pre-amp is on!

chintav1
chintav1 previously approved these changes Oct 2, 2023
View reviewed changes
xenown
xenown requested changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@xenown xenown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from Set Fixed Band, LGTM.

src/main/main.ts Show resolved Hide resolved
@selinali2010 selinali2010 dismissed stale reviews from chintav1 and h39s via cc86f6b October 3, 2023 00:43
xenown
xenown approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@xenown xenown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@selinali2010 selinali2010 merged commit fffc53c into main Oct 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenown xenown xenown approved these changes

@h39s h39s h39s left review comments

@chintav1 chintav1 chintav1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@selinali2010 @chintav1 @h39s @xenown