Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ops: poetrify #120

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ops: poetrify #120

wants to merge 1 commit into from

Conversation

kerberizer
Copy link
Member

@kerberizer kerberizer commented May 15, 2024

  • switch from setup.py to pyproject.toml (info)
  • use poetry for dependency management and project packaging
  • reogragnize accordingly the development and testing workflows
  • drop the unmaintained environment.yml and requirements.txt files
  • other ops improvements

@kerberizer kerberizer added the enhancement New feature or request label May 15, 2024
@kerberizer kerberizer requested a review from vedina May 15, 2024 14:38
@kerberizer kerberizer self-assigned this May 15, 2024
Copy link

github-actions bot commented May 15, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@kerberizer kerberizer marked this pull request as draft May 15, 2024 14:47
@kerberizer
Copy link
Member Author

There's still work to better integrate tox with poetry.

@kerberizer kerberizer force-pushed the poetrify branch 2 times, most recently from cdfa1f1 to 9ca1c18 Compare May 16, 2024 09:59
@kerberizer
Copy link
Member Author

kerberizer commented Jun 4, 2024

I'm now considering replacing Poetry with Hatch. Hatch is more standards compliant and is maintained by PyPA themselves. Poetry does have its own strengths, but one specific benefit of Hatch over it is that it can replace tox completely, e.g., by supporting multiple virtual environments vs a single one in the case of Poetry.

Edit: Still no editable dependencies might be a dealbreaker for Hatch though: pypa/hatch#588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant