Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 fix: snackbar z-index #680

Merged
merged 2 commits into from
Aug 30, 2023
Merged

🚀 fix: snackbar z-index #680

merged 2 commits into from
Aug 30, 2023

Conversation

christian-benseler-gympass
Copy link
Contributor

Description 📄

The Snackbar in the web version had a fixed z-index value (of 100). If there is in the document any other fixed or absolute positioned element with a higher z-index, the snackbar is shown below it.
To avoid this, it is possible to calculate the z-index when the element is rendered traversing the document's nodes, checking the z-index of each one and returning the max value.
Just to keep the old behavior and guarantee a high value for the property, the minimum value will be 100.

[Enter the description of your changes]

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

Through the browser, creating a div with a high z-index value (200) in the .mdx

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

Old behaviour:
Captura de ecrã 2023-08-25, às 16 38 54
Div with z-index greater than 100m snackbar is below.

New behaviour:
Captura de ecrã 2023-08-25, às 16 45 11

@matheushdsbr matheushdsbr merged commit 33d1e8b into master Aug 30, 2023
3 checks passed
@matheushdsbr matheushdsbr deleted the fix-zindexsnackbar branch August 30, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants