Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 feat(stepper): add custom color for stepper #673

Merged
merged 6 commits into from
Aug 3, 2023
Merged

🚀 feat(stepper): add custom color for stepper #673

merged 6 commits into from
Aug 3, 2023

Conversation

Falkaniere
Copy link
Contributor

JIRA Issue

Description 📄

We add a prop for Stepper receive a custom color.

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

  • use a stepper component with color prop.

  • Unit Test

  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

Girl in a jacket

@Falkaniere Falkaniere self-assigned this Jul 31, 2023
@Falkaniere Falkaniere marked this pull request as ready for review July 31, 2023 16:45
@Falkaniere @codacy-production
Update packages/yoga/src/Stepper/native/Dots.jsx
89fa10a 
Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com>
@Falkaniere @codacy-production
Update packages/yoga/src/Stepper/native/Dots.jsx
dea9d9f 
Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com>
codacy-production[bot]
codacy-production bot reviewed Aug 3, 2023
View reviewed changes
packages/yoga/src/Stepper/native/Dots.jsx
`,
return css`
width: 95px;
margin-top: 10px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Delete ··

Suggested change
margin-top: 10px;
margin-top: 10px;

codacy-production[bot]
codacy-production bot reviewed Aug 3, 2023
View reviewed changes
packages/yoga/src/Stepper/native/Dots.jsx
text-align: center;
`,
return css`
width: 95px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Delete ··

Suggested change
width: 95px;
width: 95px;

codacy-production[bot]
codacy-production bot reviewed Aug 3, 2023
View reviewed changes
packages/yoga/src/Stepper/native/Dots.jsx
: stepper.label.color.inactive};
font-size: ${stepper.label.font.size}px;
text-align: center;
`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Replace ···· with ··

Suggested change
`;
`;

codacy-production[bot]
codacy-production bot reviewed Aug 3, 2023
View reviewed changes
packages/yoga/src/Stepper/native/Dots.jsx
margin-top: 10px;
margin-left: -40px;
}) => {
const state = secondary ? 'secondary' : 'active';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Delete ··

Suggested change
const state = secondary ? 'secondary' : 'active';
const state = secondary ? 'secondary' : 'active';

codacy-production[bot]
codacy-production bot reviewed Aug 3, 2023
View reviewed changes
packages/yoga/src/Stepper/native/Dots.jsx
font-size: ${stepper.label.font.size}px;
text-align: center;
`,
return css`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Delete ··

Suggested change
return css`
return css`

codacy-production[bot]
codacy-production bot reviewed Aug 3, 2023
View reviewed changes
packages/yoga/src/Stepper/native/Dots.jsx
? stepper.label.color[state]
: stepper.label.color.inactive};
font-size: ${stepper.label.font.size}px;
text-align: center;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Delete ··

Suggested change
text-align: center;
text-align: center;

codacy-production[bot]
codacy-production bot reviewed Aug 3, 2023
View reviewed changes
packages/yoga/src/Stepper/native/Dots.jsx
);

const Label = styled(Text.Bold)(
({
active,
secondary,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Replace ···· with ··

Suggested change
secondary,
secondary,

codacy-production[bot]
codacy-production bot reviewed Aug 3, 2023
View reviewed changes
packages/yoga/src/Stepper/native/Dots.jsx
margin-left: -40px;
color: ${active
? stepper.label.color[state]
: stepper.label.color.inactive};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Replace ········ with ······

Suggested change
: stepper.label.color.inactive};
: stepper.label.color.inactive};

codacy-production[bot]
codacy-production bot reviewed Aug 3, 2023
View reviewed changes
packages/yoga/src/Stepper/native/Dots.jsx
width: 95px;
margin-top: 10px;
margin-left: -40px;
color: ${active
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Delete ··

Suggested change
color: ${active
color: ${active

codacy-production[bot]
codacy-production bot reviewed Aug 3, 2023
View reviewed changes
packages/yoga/src/Stepper/native/Dots.jsx
width: 95px;
margin-top: 10px;
margin-left: -40px;
}) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Delete ··

Suggested change
}) => {
}) => {

codacy-production[bot]
codacy-production bot reviewed Aug 3, 2023
View reviewed changes
packages/yoga/src/Stepper/native/Dots.jsx
return css`
width: 95px;
margin-top: 10px;
margin-left: -40px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Delete ··

Suggested change
margin-left: -40px;
margin-left: -40px;

codacy-production[bot]
codacy-production bot reviewed Aug 3, 2023
View reviewed changes
packages/yoga/src/Stepper/native/Dots.jsx
color: ${active
? stepper.label.color[state]
: stepper.label.color.inactive};
font-size: ${stepper.label.font.size}px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Delete ··

Suggested change
font-size: ${stepper.label.font.size}px;
font-size: ${stepper.label.font.size}px;

codacy-production[bot]
codacy-production bot reviewed Aug 3, 2023
View reviewed changes
packages/yoga/src/Stepper/native/Dots.jsx
margin-top: 10px;
margin-left: -40px;
color: ${active
? stepper.label.color[state]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Delete ··

Suggested change
? stepper.label.color[state]
? stepper.label.color[state]

@rafaelcoletagympass rafaelcoletagympass merged commit c0771a3 into master Aug 3, 2023
2 of 3 checks passed
@rafaelcoletagympass rafaelcoletagympass deleted the feat/customColor-stepper-component branch August 3, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codacy-production codacy-production[bot] codacy-production[bot] left review comments

@luanlorenzo luanlorenzo luanlorenzo left review comments

@rafaelcoletagympass rafaelcoletagympass rafaelcoletagympass approved these changes

@matheushdsbr matheushdsbr matheushdsbr approved these changes

Assignees

@Falkaniere Falkaniere

Labels
@gympass/yoga
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Falkaniere @luanlorenzo @matheushdsbr @rafaelcoletagympass @ericcleao