Deprecate Utility for removal #10083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going forward, GWT builds will contain Java 11 bytecode and be able to use Java 11 language and jre improvements.
|
Passing nightly CI build https://github.com/niloc132/gwt/actions/runs/12697583846/job/35394205582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class is an odd mix of useful methods, and was used all over the code base. Many of the methods have a better way to implement them in modern Java (try-with-resources,
InputStream.transferTo(),InputStream.readAllBytes(),java.nioutilities), and some had odd quirks or bugs (closing while writing a buffer file must be allowed to throw an error! don't double-buffer reads or writes!, especially when you're just pulling the results into memory anyway!).Some methods have been moved to their own types, to be closer to their use and not effectively require every class have access to this same package - SourceLevel, LinkerUtils, and CommandLineCreatorUtils
Also modified CompilerTest and RecompilerTest to also avoid deprecated Guava
Files.createTempDir(),Files.write(), etc in favor ofjava.nio.file.Files.The class itself has been deprecated for removal, allowing downstream Generators/Linkers/etc time to update.
Fixes #10031