Implement Java 8 String.split() semantics #10054
Open
+47
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may want to offer a property to reflect the old behavior since it it has been so long that we haven't had this. |
|
Passing nightly build https://github.com/niloc132/gwt/actions/runs/12236319531 |
Should we actually keep the old behavior as the default with a property or a flag to switch to the new correct behavior, we keep this for a while but we make sure to generate a warning when old behavior is used, later we remove it at all.. WDYT? |
vegegoku
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Java 8, String.split() changed to not return an initial empty string on a zero-width match. This patch brings GWT's String emulation in compliance with that specification change.
Added additional tests for non-zero-width matches and verifying behavior on all-empty matches. Compile time constant tests also updated to match.
Fixes #8868