feat: make entire tip resource area clickable #89
Conversation
| icon: const Icon(Icons.link), | ||
| ), | ||
| ], | ||
| body: InkWell( |
There was a problem hiding this comment.
The body should open and close when clicked, not open the link
| @@ -27,7 +27,7 @@ class AllTipsPage extends StatelessWidget { | |||
| trailing: const Icon(Icons.arrow_forward), | |||
| onTap: () => Navigator.of(context).push( | |||
| MaterialPageRoute( | |||
| builder: (context) => TipInformationPage(tip), | |||
…nto tip_buttons
|
Could you please elaborate? I can't seem to find any comments added to the files in this PR. |
.
|
|
|
|
Hey, Thanks |
| icon: const Icon(Icons.link), | ||
| ), | ||
| ], | ||
| body: InkWell( |
There was a problem hiding this comment.
The body should open and close when clicked, not open the link
|
I took the liberty of replacing Icon Button with Icon as InkWell makes the entire area clickable and makes Icon Button redundant. I also added Padding to the text to improve the look |
|
Maybe I wasn't clear Area number 1 only expends and retracts when clicked.
It is not what you have done, please fix |
|
I guess there was a communication gap, I will modify my implementation |
|
Still working on this, I can't unrequest reviews so don't review it yet |
|
Alright, I'm done |
| isExpanded.forEach((key, value) { | ||
| isExpanded[key] = false; | ||
| }); | ||
| isExpanded[isExpanded.keys | ||
| .elementAt(panelIndex)] = expanded; |
There was a problem hiding this comment.
I don't like this code, it does not look clean.
fixed issue as mentioned in #86