Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding notifications #135

Merged
merged 20 commits into from
Jun 24, 2024
Merged

Adding notifications #135

merged 20 commits into from
Jun 24, 2024

Conversation

guyluz11
Copy link
Owner

No description provided.

@guyluz11 guyluz11 marked this pull request as draft June 11, 2024 12:08
@guyluz11
Copy link
Owner Author

Missing

  • Resuming the page and timer state if the user resumes the app before the timer is completed, upcoming notifications should get canceled.
  • Make each notification sound correspond to the timer-type sound.
  • Change notification icon.
  • Check on iPhone.
  • Create new issues, one is a popup to approve permissions the first time entering the app. And adding a permission option in the settings popup.

guyluz11
guyluz11 commented Jun 23, 2024
View reviewed changes
Copy link
Owner Author

@guyluz11 guyluz11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix comments

ios/Runner.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
ios/Runner/Info.plist Outdated Show resolved Hide resolved
lib/domain/energy_level.dart Outdated Show resolved Hide resolved
lib/domain/preferences_controller.dart Outdated Show resolved Hide resolved
lib/infrastructure/preferences_repository.dart Outdated Show resolved Hide resolved
lib/presentation/organisms/timer_organism.dart Outdated Show resolved Hide resolved
lib/presentation/organisms/timer_organism.dart Show resolved Hide resolved
lib/presentation/pages/home_page.dart Show resolved Hide resolved
lib/presentation/pages/home_page.dart Outdated Show resolved Hide resolved
lib/presentation/pages/home_page.dart Outdated Show resolved Hide resolved
@guyluz11 guyluz11 marked this pull request as ready for review June 24, 2024 08:51
@guyluz11 guyluz11 linked an issue Jun 24, 2024 that may be closed by this pull request
No sound on lock screen #69
Closed
@guyluz11 guyluz11 mentioned this pull request Jun 24, 2024
Closed
@guyluz11 guyluz11 merged commit 8fe69df into dev Jun 24, 2024
2 checks passed
@guyluz11 guyluz11 deleted the adding_notifications branch June 24, 2024 09:08
@guyluz11 guyluz11 mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No sound on lock screen
1 participant
@guyluz11