Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arbitrary teleport #8

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add arbitrary teleport #8

wants to merge 7 commits into from

Conversation

aphkyle
Copy link

@aphkyle aphkyle commented Mar 3, 2022

😈😈😈😈

@aphkyle
Add arbitary teleport
dcc4651 
😈😈😈😈
@aphkyle
Copy link
Author

aphkyle commented Mar 3, 2022 •
edited
Loading

#7

@aphkyle aphkyle changed the title Add arbitary teleport Add arbitrary teleport Mar 3, 2022
gustavwilliam
gustavwilliam requested changes Mar 3, 2022
View reviewed changes
Copy link
Member

@gustavwilliam gustavwilliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LAGTM (looks almost good to me). This is a pure code review, since I have no idea how to run and test this.

Looks good in general, but there are a few comments and spacing issues that I've pointed out in comments.

src/generators/05_arbitrary_teleport.py Outdated Show resolved Hide resolved
src/generators/05_arbitrary_teleport.py Outdated Show resolved Hide resolved
src/generators/05_arbitrary_teleport.py Show resolved Hide resolved
src/generators/05_arbitrary_teleport.py Outdated Show resolved Hide resolved
@aphkyle
Copy link
Author

aphkyle commented Mar 3, 2022

oh, hang on the default value thing didn't work 🥴 will have to figure it out for a while brb

@aphkyle
remove floating digits
68e8209 
apparently those wont work on minecraft scoreboard, it has to be integer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavwilliam gustavwilliam gustavwilliam requested changes

@Akarys42 Akarys42 Awaiting requested review from Akarys42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aphkyle @gustavwilliam