Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added extension management commands #157

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: added extension management commands #157

wants to merge 4 commits into from
+320 −7

Conversation

onerandomusername
Copy link
Contributor

closes GH-15

@gustavwilliam
Copy link
Member

Is this based on the corresponding Python Discord bot commands (Python or Sir Lancebot)?

@onerandomusername
Copy link
Contributor Author

Is this based on the corresponding Python Discord bot commands (Python or Sir Lancebot)?

This is based on my own bot's implementation which was based on both Python Discord's Python and Sir Lancebot

@onerandomusername onerandomusername added priority: high High priority area: backend status: needs review type: feature A request for or implementation of a new feature labels Jan 14, 2022
@onerandomusername
Copy link
Contributor Author

@gustavwilliam

vivekashok1221
vivekashok1221 requested changes Feb 20, 2023
View reviewed changes
Copy link
Member

@vivekashok1221 vivekashok1221 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I typed these suggestions about a year ago but didn't get time to submit. I'll probably need to test the bot again. And maybe even review it once more.

bot/exts/backend/extension_manager.py Outdated Show resolved Hide resolved
bot/utils/extensions.py Outdated Show resolved Hide resolved
bot/utils/extensions.py Outdated Show resolved Hide resolved
bot/exts/backend/extension_manager.py Outdated Show resolved Hide resolved
onerandomusername and others added 2 commits February 20, 2023 14:03
@onerandomusername
feat: added extension management commands
2122f67 
took these from my own project, removed some features that weren't relevent/part of the spec
includes commands to load, reload, or unload extensions
commands are role-locked to the steering council
@onerandomusername
import from disnake
f84d799
vivekashok1221
vivekashok1221 approved these changes Dec 25, 2023 •
edited
Loading
View reviewed changes
vivekashok1221
vivekashok1221 approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@vivekashok1221 vivekashok1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works. My comments have also been addressed. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekashok1221 vivekashok1221 vivekashok1221 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
area: backend priority: high High priority status: needs review type: feature A request for or implementation of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load/Unload Cogs
3 participants
@onerandomusername @gustavwilliam @vivekashok1221