Improve s3 download logs

guardian · Jan 10, 2025 · 105b12c · 105b12c
1 parent 505d7b2
commit 105b12c
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/backend-common/src/s3.ts b/packages/backend-common/src/s3.ts
@@ -164,6 +164,8 @@ export const downloadObject = async (
 	return data.Metadata?.['extension'];
 };
 
+const bytesToMB = (bytes: number) => bytes / 1024 / 1024;
+
 const downloadS3Data = async (
 	data: Readable,
 	destinationPath: string,
@@ -172,9 +174,10 @@ const downloadS3Data = async (
 ) => {
 	let downloadedBytes = 0;
 	let lastLoggedPercentage = 0;
+	const contentLengthMb = contentLength && bytesToMB(contentLength);
 	data.on('data', (chunk) => {
 		downloadedBytes += chunk.length;
-		if (contentLength) {
+		if (contentLength && contentLengthMb) {
 			const percentage = Math.floor((downloadedBytes / contentLength) * 100);
 			if (
 				downloadedBytes > 0 &&
@@ -183,7 +186,7 @@ const downloadS3Data = async (
 			) {
 				lastLoggedPercentage = percentage;
 				logger.info(
-					`Downloaded ${downloadedBytes} of ${contentLength} bytes so far ${contentLength ? `(${percentage}%)` : ''} for ${key}`,
+					`Downloaded ${bytesToMB(downloadedBytes)} of ${contentLengthMb} MB so far (${percentage}%) for ${key}`,
 				);
 			}
 		}
@@ -193,7 +196,6 @@ const downloadS3Data = async (
 		data
 			.pipe(stream)
 			.on('finish', () => {
-				logger.debug('stream pipe done');
 				resolve();
 			})
 			.on('error', (error) => {