update to latest GuCDK/CDK #2660
Conversation
| "LoggingConfig": { | ||
| "LogFormat": "JSON", | ||
| }, |
There was a problem hiding this comment.
default is now JSON
guardian/cdk#2260
There was a problem hiding this comment.
it doesn't look reasonable at all, so I think we will have to override this everywhere
BEFORE
AFTER
| "Tags": [ | ||
| { | ||
| "Key": "App", | ||
| "Value": "alarms-handler", | ||
| }, | ||
| { | ||
| "Key": "gu:cdk:version", | ||
| "Value": "TEST", | ||
| }, | ||
| { | ||
| "Key": "gu:repo", | ||
| "Value": "guardian/support-service-lambdas", | ||
| }, | ||
| { | ||
| "Key": "Stack", | ||
| "Value": "membership", | ||
| }, | ||
| { | ||
| "Key": "Stage", | ||
| "Value": "CODE", | ||
| }, | ||
| ], |
There was a problem hiding this comment.
these are mostly standard tags that devex like to have on everything to help with their analysis. They would not cause any rumtime issues.
| "states", | ||
| ], | ||
| }, | ||
| "Service": "states.amazonaws.com", |
There was a problem hiding this comment.
I assume we had to use the right url before, but AWS have made a standard one now. I haven't looked it up for sure though to confirm.
| @@ -389,7 +283,7 @@ exports[`The discount-expiry-notifier stack matches the snapshot 1`] = ` | |||
| "Arn", | |||
| ], | |||
| }, | |||
| "","Payload.$":"$"}},"Email sends processor map":{"Type":"Map","ResultPath":"$.discountProcessingAttempts","Next":"Save results","Parameters":{"item.$":"$$.Map.Item.Value"},"Iterator":{"StartAt":"Check sub is active","States":{"Check sub is active":{"Next":"Is Subscription Active?","Retry":[{"ErrorEquals":["Lambda.ClientExecutionTimeoutException","Lambda.ServiceException","Lambda.AWSLambdaException","Lambda.SdkClientException"],"IntervalSeconds":2,"MaxAttempts":6,"BackoffRate":2}],"Type":"Task","OutputPath":"$.Payload","Resource":"arn:", | |||
| "","Payload.$":"$"}},"Email sends processor map":{"Type":"Map","ResultPath":"$.discountProcessingAttempts","Next":"Save results","Parameters":{"item.$":"$$.Map.Item.Value"},"ItemsPath":"$.expiringDiscountsToProcess","MaxConcurrency":10,"Iterator":{"StartAt":"Check sub is active","States":{"Check sub is active":{"Next":"Is Subscription Active?","Retry":[{"ErrorEquals":["Lambda.ClientExecutionTimeoutException","Lambda.ServiceException","Lambda.AWSLambdaException","Lambda.SdkClientException"],"IntervalSeconds":2,"MaxAttempts":6,"BackoffRate":2}],"Type":"Task","OutputPath":"$.Payload","Resource":"arn:", | |||
There was a problem hiding this comment.
this is just a reordering of the values
| @@ -563,6 +575,7 @@ def submit_response(event: dict, context, response_status: str, error_message: s | |||
| "Arn", | |||
| ], | |||
| }, | |||
| "SkipDestinationValidation": false, | |||
| managed = props.get('Managed', 'true').lower() == 'true' | ||
| skipDestinationValidation = props.get('SkipDestinationValidation', 'false').lower() == 'true' |
There was a problem hiding this comment.
this is a lambda that is defined by CDK itself, rahter than AWS functuoinality. they have updated the implementation and python version, causing a lot of diffs, but (hopefully) the lambda will work the same
| @@ -15,11 +15,11 @@ | |||
| "fix-formatting": "prettier --write **.ts" | |||
| }, | |||
| "devDependencies": { | |||
| "@guardian/cdk": "52.3.0", | |||
| "@guardian/cdk": "61.1.2", | |||
There was a problem hiding this comment.
| "aws-cdk": "2.175.1", | ||
| "aws-cdk-lib": "2.175.1", |
There was a problem hiding this comment.
We are on quite an old GuCDK.
This PR updates to the latest.
This is needed so that I can add tags to alarms, which has only been supported since aws/aws-cdk#29759 (comment)
I have commented all the types of change that are in the files, but I think the only one that would change the behaviour would be the log format.
TODO show an example of the new log format in this description