Discount expiry notifier - Create state machine #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdk/bin/cdk.ts
Outdated
| @@ -287,3 +288,11 @@ new UserBenefits(app, 'user-benefits-PROD', { | |||
| supporterProductDataTable: | |||
| 'supporter-product-data-tables-PROD-SupporterProductDataTable', | |||
| }); | |||
| new DiscountExpiryNotifier(app, 'discount-expiry-notifier-CODE', { | |||
| stack: 'membership', | |||
There was a problem hiding this comment.
Super minor comment is that I just remembered that we'd prefer going forward to use support rather than membership as a stack name.
It would mean updating those values where they come up (cdk and riff raff) and redeploy.
This is not a "must do".
AndreaDiotallevi
approved these changes
Jan 13, 2025
david-pepper
deleted the
create-discount-expiry-notifier-state-machine
branch
david-pepper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Add a new state machine that will contain functions that orchestrate a notification to customers with a discount that is soon to expire.
Discounted Subs Notifications - Proposed Process flow
Notes
Empty lambda is present in these changes. Seems like this is the easy way to introduce a new state machine in support -service-lambdas. This lambda (getSubsWithExpiringDiscounts) will be the fleshed out in the next piece of work.