remove invoicing api call from holiday stop processor #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get a lot of errors from the holiday stop API, because it makes calls to the invoicing API.
The reason it makes the calls is that there was a migration in progress to make it more accurately determine the invoice date - the original (unfinished) work to switch over was in #751
The issue still needs fixing but we have decided on a different route - see #2243 for the WIP on that.
The reason this is affecting us now is that the API key needed was rotated/deleted at some point thus breaking the link and causing errors in the logs. This is misleading and makes it hard to investigate.
The long term solution is to finish the above PR, but for now this PR just deletes the unused call to invoicing api.
Tested in CODE, all unit tests pass.