WIP get billing preview when holiday stop api is called #2243
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package com.gu.holiday_stops | ||
|
|
||
| import cats.Id | ||
| import com.gu.holiday_stops.Handler.{getAccessTokenFromZuora, getBillingPreviewFromZuora} | ||
| import com.gu.test.EffectsTest | ||
| import org.scalatest.flatspec.AnyFlatSpec | ||
| import org.scalatest.matchers.should.Matchers | ||
| import sttp.client3.HttpURLConnectionBackend | ||
| import sttp.client3.logging.{LogLevel, Logger, LoggingBackend} | ||
|
|
||
| import java.time.LocalDate | ||
|
|
||
| class GetBillingPreviewEffectsTest extends AnyFlatSpec with Matchers { | ||
|
|
||
| lazy val config = { | ||
| zio.Runtime.default.unsafeRun { | ||
| Configuration.config.provideLayer(ConfigurationLive.impl) | ||
| } | ||
| } | ||
|
|
||
| lazy val backend = LoggingBackend( | ||
| HttpURLConnectionBackend(), | ||
| new Logger[Id] { | ||
| override def apply(level: LogLevel, message: => String): Id[Unit] = info("LOG: " + message) | ||
|
|
||
| override def apply(level: LogLevel, message: => String, t: Throwable): Id[Unit] = | ||
| info("LOG: " + message + t.toString) | ||
| }, | ||
| logResponseBody = true, | ||
| ) | ||
|
|
||
| "get billing preview" should "fetch a test subscription's preview" taggedAs EffectsTest ignore { | ||
|
|
||
| val ACCOUNT_TO_USE = "A00211577" | ||
|
|
||
| val op = getBillingPreviewFromZuora(config, backend) | ||
| val accessToken = getAccessTokenFromZuora(config, backend).toOption.get | ||
|
|
||
| val preview = op.getBillingPreview(accessToken, ACCOUNT_TO_USE, LocalDate.now.plusMonths(13)) | ||
| info("preview is: " + preview) | ||
| preview.toOption.get.length shouldBe 26 | ||
|
There was a problem hiding this comment. what is this line checking, out of interest? we might want to be aware that this is a real account in the api sandbox, and its state may change (it currently has two active subscriptions, but one or both could be cancelled any time, or more could be acquired). There was a problem hiding this comment. yeah it's good to flag this - this is more like a manual test, as I couldn't think of a quick way to make it reliable. It should be left as "ignore" unless it's being used. To answer your question it's just checking that 26 items were returned for the 13 months (rather than an error). so not really a completely useful assertion. |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| package com.gu.zuora.subscription | ||
|
|
||
| import com.gu.zuora.{AccessToken, ZuoraConfig} | ||
| import io.circe.generic.semiauto._ | ||
| import io.circe.{Decoder, Encoder, HCursor} | ||
| import sttp.client3._ | ||
| import sttp.client3.circe._ | ||
|
|
||
| import java.time.LocalDate | ||
|
|
||
| object GetBillingPreview { | ||
|
|
||
| case class InvoiceItem( | ||
| serviceStartDate: LocalDate, | ||
| serviceEndDate: LocalDate, | ||
| chargeId: String, | ||
| ) | ||
| implicit val decode: Decoder[InvoiceItem] = deriveDecoder | ||
| // implicit val decode: Decoder[InvoiceItem] = (c: HCursor) => | ||
| // for { | ||
| // chargeDate <- c.downField("chargeDate").as[String].map(_.takeWhile(_ != ' ')).map(LocalDate.parse) | ||
| // chargeId <- c.downField("chargeId").as[String] | ||
| // } yield InvoiceItem(chargeDate, chargeId) | ||
|
|
||
| case class BillingPreview( | ||
| invoiceItems: List[InvoiceItem], | ||
| ) | ||
| implicit val decode2: Decoder[BillingPreview] = deriveDecoder | ||
| implicit val encode: Encoder[BillingPreviewRequest] = deriveEncoder | ||
| case class BillingPreviewRequest( | ||
| accountNumber: String, | ||
| targetDate: LocalDate, | ||
| assumeRenewal: String = "Autorenew", | ||
| ) | ||
| } | ||
|
|
||
| trait GetBillingPreview { | ||
| import GetBillingPreview._ | ||
| def getBillingPreview( | ||
| accessToken: AccessToken, | ||
| accountNumber: String, | ||
| targetDate: LocalDate, // target date is how far in the future to go to | ||
| ): Either[ApiFailure, List[InvoiceItem]] | ||
| } | ||
|
|
||
| // https://developer.zuora.com/v1-api-reference/api/operation/POST_BillingPreview/ | ||
| object GetBillingPreviewLive { | ||
|
|
||
| def billingPreviewGetResponse( | ||
| config: ZuoraConfig, | ||
| backend: SttpBackend[Identity, Any], | ||
| ): GetBillingPreview = | ||
| (accessToken: AccessToken, accountNumber: String, targetDate: LocalDate) => { | ||
| val request = GetBillingPreview.BillingPreviewRequest(accountNumber, targetDate) | ||
| basicRequest | ||
| .post(uri"${config.baseUrl}/operations/billing-preview") | ||
| .body(request) | ||
| .header("Authorization", s"Bearer ${accessToken.access_token}") | ||
| .response(asJson[GetBillingPreview.BillingPreview]) | ||
| .mapResponse(_.left.map(e => ZuoraApiFailure(e.getMessage))) | ||
| .send(backend) | ||
| .body | ||
| .map(_.invoiceItems) | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove Mario's invoicing-api experiment (testInProdPreviewPublications) as part of this? This is currently erroring due to a problem with invoicing-api credentials, but if it were working it would also be requesting a billing-preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in #2504